Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links should go to a new tab / window. OR the app should remember filter settings #150

Open
carlshimer opened this issue Nov 16, 2015 · 1 comment

Comments

@carlshimer
Copy link

Use case:

  1. Have a project selected as a filter and a label selected as a filter.
  2. Scrolled way down to an obscure ticket.
  3. Click on a link in the ticket. You now go to the new page, but on back all of the filter settings and position information is lost.

Seems like there are a couple of solutions:

  1. Always link off the site for external links (any links)
  2. remember in the URL the filter settings to reload the page properly. Also would handle the link sharing use case.
@dahlbyk
Copy link
Member

dahlbyk commented Mar 9, 2016

  1. Always link off the site for external links (any links)

We already do this when we link issue numbers out to the corresponding GitHub issue, but we definitely need to do the same for links within issue descriptions/comments.

  1. remember in the URL the filter settings to reload the page properly. Also would handle the link sharing use case.

Interesting...so we have almost all the pieces in place to do this already, we just don't quite do it correctly.

Also preserving scroll position adds another level of complexity that I'm honestly not sure how we would be able to handle browser-wise, even if we didn't completely refresh the board when you navigate Back. Any ideas there?

All that said, we'll be able to fix the former much more easily than the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants