From f3d8f47dd3d47210cbe00f12d26655738f2696a3 Mon Sep 17 00:00:00 2001 From: LoserCheems <3314685395@qq.com> Date: Fri, 24 Jan 2025 12:52:08 +0800 Subject: [PATCH 1/3] Fixed bug of import url_to_fs from fsspec (#507) --- src/lighteval/logging/evaluation_tracker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lighteval/logging/evaluation_tracker.py b/src/lighteval/logging/evaluation_tracker.py index af5784bc2..c323aaea6 100644 --- a/src/lighteval/logging/evaluation_tracker.py +++ b/src/lighteval/logging/evaluation_tracker.py @@ -34,7 +34,7 @@ import torch from datasets import Dataset, load_dataset from datasets.utils.metadata import MetadataConfigs -from fsspec import url_to_fs +from fsspec.core import url_to_fs from huggingface_hub import DatasetCard, DatasetCardData, HfApi, HFSummaryWriter, hf_hub_url from lighteval.logging.info_loggers import ( From c6a226eb689500c8448e9facb6d0f8d92baf7345 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Fourrier?= <22726840+clefourrier@users.noreply.github.com> Date: Fri, 24 Jan 2025 09:14:31 +0100 Subject: [PATCH 2/3] Add a try catch as import depend on fsspec version --- src/lighteval/logging/evaluation_tracker.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lighteval/logging/evaluation_tracker.py b/src/lighteval/logging/evaluation_tracker.py index c323aaea6..f22f69b3d 100644 --- a/src/lighteval/logging/evaluation_tracker.py +++ b/src/lighteval/logging/evaluation_tracker.py @@ -34,7 +34,10 @@ import torch from datasets import Dataset, load_dataset from datasets.utils.metadata import MetadataConfigs -from fsspec.core import url_to_fs +try: + from fsspec import url_to_fs +except ImportError: + from fsspec.core import url_to_fs from huggingface_hub import DatasetCard, DatasetCardData, HfApi, HFSummaryWriter, hf_hub_url from lighteval.logging.info_loggers import ( From d2b1bc82fad658d33c6179f0ffb6b95d82f0714d Mon Sep 17 00:00:00 2001 From: LoserCheems <3314685395@qq.com> Date: Fri, 24 Jan 2025 16:45:31 +0800 Subject: [PATCH 3/3] Fixed code quality --- src/lighteval/logging/evaluation_tracker.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lighteval/logging/evaluation_tracker.py b/src/lighteval/logging/evaluation_tracker.py index f22f69b3d..585d74232 100644 --- a/src/lighteval/logging/evaluation_tracker.py +++ b/src/lighteval/logging/evaluation_tracker.py @@ -34,10 +34,6 @@ import torch from datasets import Dataset, load_dataset from datasets.utils.metadata import MetadataConfigs -try: - from fsspec import url_to_fs -except ImportError: - from fsspec.core import url_to_fs from huggingface_hub import DatasetCard, DatasetCardData, HfApi, HFSummaryWriter, hf_hub_url from lighteval.logging.info_loggers import ( @@ -56,6 +52,11 @@ if is_nanotron_available(): from nanotron.config import GeneralArgs # type: ignore +try: + from fsspec import url_to_fs +except ImportError: + from fsspec.core import url_to_fs + class EnhancedJSONEncoder(json.JSONEncoder): """