Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question abour webPreferences for controlView #20

Open
raphael10-collab opened this issue Jul 29, 2022 · 0 comments
Open

Question abour webPreferences for controlView #20

raphael10-collab opened this issue Jul 29, 2022 · 0 comments

Comments

@raphael10-collab
Copy link

raphael10-collab commented Jul 29, 2022

It's not clear to me why for new Tab:

sandbox: true

https://github.com/hulufei/electron-as-browser/blob/master/index.js#L390

but for controlView

contextIsolation : false,
nodeIntegraion: true

https://github.com/hulufei/electron-as-browser/blob/master/index.js#L80

Is it enough secure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant