Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP Metadata cannot be generated without a config XML file in place #87

Closed
shadyvb opened this issue Oct 25, 2021 · 4 comments
Closed

SP Metadata cannot be generated without a config XML file in place #87

shadyvb opened this issue Oct 25, 2021 · 4 comments
Assignees
Labels
bug Existing functionality isn't behaving as expected

Comments

@shadyvb
Copy link
Contributor

shadyvb commented Oct 25, 2021

The module expects a config file to exist, and falls back to the default file in .sso/config from the skeleton project, which doesn't necessarily exist on all installations.

Steps to reproduce:

  1. Remove the .config/sso/saml-idp-metadata.xml file
  2. Try to generate the SP metadata XML by visiting https://site/sso/metadata

You should see the SP metadata XML file generated, but right now it errors out with Invalid SSO settings. Contact your administrator.

The solution would be to move the default file to the module directory to ensure it always exists, and load it from there, and remove it from the skeleton project.

Related to support request: https://humanmade.zendesk.com/agent/tickets/5673

@shadyvb shadyvb added the bug Existing functionality isn't behaving as expected label Oct 25, 2021
@roborourke
Copy link
Contributor

I'm a bit lost, the skeleton project doesn't contain any sample metadata file at all, you have to create it as far as I knew - you get the file from your SAML provider and add it to your project. When I set this up locally and tested I had to spin up the local docker container, get the file contents and create it, then I could proceed from there.

Is this about using the site itself as the SAML provider? I didn't think the plugin had that ability.

@shadyvb
Copy link
Contributor Author

shadyvb commented Oct 26, 2021

You're correct, see #88 (comment), previously I was asked to provide the SP metadata in order to get the IdP one, apparently there was a misunderstanding there or a different process maybe, can't remember the details.

I closed the PR and the next steps would be:

  • Update the plugin to provide a way for admins to view the integration values ( redirect, acs urls, etc ), and update docs to reference that.
  • Remove references to the testing file and instructions, should already exist within the plugin

@roborourke
Copy link
Contributor

I think I'm with you now, browsing to /sso/metadata gives me the right info though but agree we could maybe expose some means of directly downloading that via the admin. This module I think hides the UI as you noted so we can look at just showing that again - where possible what we've done is hide parts of the UI that have configured through code, but otherwise show them.

roborourke added a commit that referenced this issue Oct 26, 2021
hm-backport bot pushed a commit that referenced this issue Oct 29, 2021
@roborourke
Copy link
Contributor

Closing out as the docs were updated in #89 - it seems it's intended behaviour to require the config XML in order to generate the metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants