Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pattern length restriction #2005

Open
theGreatWhiteShark opened this issue Aug 8, 2024 · 0 comments
Open

Remove pattern length restriction #2005

theGreatWhiteShark opened this issue Aug 8, 2024 · 0 comments
Milestone

Comments

@theGreatWhiteShark
Copy link
Contributor

As discussed in #2001 it would be favorable to drop the restriction of maximum pattern length to 4 * 4/4. I do not see point why this is still relevant.

In addition, we could review some of the variables exposed in CMakeLists.txt. Increasing MAX_NOTES does somehow increase possible pattern lengths too. But in a really weird and glitchy way. Is there something off with handling this variable or is it a bad idea to expose it in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant