-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for wasm32-pyodide #190
Conversation
Hello, thanks for the response! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, not a maintainer here – but I agree with the idea. Thanks, @alarmfox!
Co-authored-by: Agriya Khetarpal <[email protected]>
@@ -46,6 +46,23 @@ class InvalidHashError(ValueError): | |||
""" | |||
|
|||
|
|||
class UnsupportedParamsError(ValueError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class needs to be added to the API docs.
""" | ||
Should fail if on wasm and parallelism > 1 | ||
""" | ||
for machine in ["wasm32", "wasm64"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make this a parametrization
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I was trying to fix it up locally, but unfortunately you opened the PR from your main branch so I couldn't push my changes. There's a reason I beg people to not do that in the PR template, so it would be nice if you could follow that advice in the future. edit: i have just noticed that this repo was lacking said template and have added it now in 8041a04 |
Summary
I was trying to use this library in Pyodide WASM runtime but it was not supported.
I added the required packages according to their guidelines. There are issues in Threading so I added a check for
parallelism != 1
based on theplatform.machine()
.Pyodide patch
Alternative solution
Pyodide supports patching: instead of providing
wheel
one could provide the source code and this patch, but there will need to build everything from scratch.Can we work this out?