Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates validator schemas to support geoJSON in the properties #24

Closed
bitbeckers opened this issue Jan 24, 2025 · 1 comment · Fixed by #25
Closed

Updates validator schemas to support geoJSON in the properties #24

bitbeckers opened this issue Jan 24, 2025 · 1 comment · Fixed by #25
Assignees
Labels
enhancement New feature or request

Comments

@bitbeckers
Copy link
Contributor

Describe the feature you'd like to request

The hypercert metadata validators should support geoJSON files in the properties

Describe the solution you'd like

Expand the schema to detect and explicitly validate geoJSON. If a link to a geoJSON was detected, the SDK should download the file and validate it's content.

Describe alternatives you've considered

Allowing for the full geoJSON to be attached to the metadata. This would make the size of the metadata unpredictable as geoJSONs can be >10MB. Which is terribel to fetching/querying hypercerts metadata (let alone on mobile)

@bitbeckers bitbeckers added the enhancement New feature or request label Jan 24, 2025
@bitbeckers bitbeckers self-assigned this Jan 26, 2025
@bitbeckers bitbeckers linked a pull request Jan 26, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In review to Done in Hypercerts dev team daily ops Feb 3, 2025
@bitbeckers
Copy link
Contributor Author

This has been implemented to only check on the structure of the geoJSON property and the path to the external resource declared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant