Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console shows incorrect approval statuses for smart contract proposal #69

Open
dkacperski97 opened this issue Oct 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dkacperski97
Copy link

Screenshot 2021-10-29 123041

The error occurs when the name and id of the organization differ in configtx.yaml, e.g.

...
Organizations:
    - &Org1
        Name: Org1
        ID: Org1MSP
...

The error does not occur with test-network because the id and name of the peer organization are the same.

The status value depends on this line of code:

const signature = commited[member.id] ? 'approval_submitted' : undefined;
The keys in the commited object are the identifiers of organizations, but member.id is actually the name of the organization.
Members are passed from the ChannelDetails component and are based on the part of the channel configuration where the names of organizations are used.
const orgNodes = _.get(config, 'channel_group.groups_map.Application.groups_map');

@varadgit
Copy link
Contributor

@dkacperski97 good analysis! Yes, console currently expects both of of those to be the same... we can look to fix handle it for some of these cases where it makes sense... sounds like you may have gotten it to work by tweaking it? if so, please feel free to make a PR... otherwise we will take a look

@dkacperski97
Copy link
Author

No, I haven't tried to fix it.

@dshuffma-ibm dshuffma-ibm self-assigned this Nov 2, 2021
@dshuffma-ibm dshuffma-ibm added the bug Something isn't working label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants