Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ginkgo integration tests to ginkgo v2 #29

Open
jkneubuh opened this issue Jul 20, 2022 · 1 comment
Open

Upgrade ginkgo integration tests to ginkgo v2 #29

jkneubuh opened this issue Jul 20, 2022 · 1 comment

Comments

@jkneubuh
Copy link
Contributor

jkneubuh commented Jul 20, 2022 •
edited
Loading

Thanks @SamYuan1990 I think this is all set. I am opening a bug / Issue to track the work items as "all done."
@jkneubuh jkneubuh changed the title Upgrade ginkgo integration tests to gingk Upgrade ginkgo integration tests to ginkgo v2 Jul 20, 2022
@jkneubuh
Copy link
Contributor Author

jkneubuh commented Nov 7, 2022

The golang dependencies for the ginkgo upgrade are a nightmare. See PR #64

The ginkgo / gomega upgrade forces a dependency upgrade of logging components, which in turn are shared by both controller-gen and the fabric-ca client. Or at least ... upgrading ginkgo is foisting an update that is bleeding up to the CA.

Before attempting the upgrade, make sure there are a lot of regression and acceptance testing mechanisms in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkneubuh