You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes I meant the Cacher interface. I thought we should include Release method in the Cacher interface because it complements the Cache method, by disabling caching of a particular item. Looking further, I noticed
Cacher interface is referenced in the client package. Here, we use only the Cache method and not the Release method.
Cache is the only implementation of Cacher interface. The Release method on it is an implementation detail, that is referenced only inside the wire package.
So, my suggestion would be that, in a separate PR:
We can make Cache, its methods and the MakeCache function unexported.
We can retain the Cacher interface, because it allows us to freely refactor the Cache implementation (like removing use of context and adding Release method, which you did in this PR).
Yes I meant the
Cacher
interface. I thought we should includeRelease
method in theCacher
interface because it complements theCache
method, by disabling caching of a particular item. Looking further, I noticedCacher
interface is referenced in the client package. Here, we use only theCache
method and not theRelease
method.Cache
is the only implementation ofCacher
interface. TheRelease
method on it is an implementation detail, that is referenced only inside the wire package.So, my suggestion would be that, in a separate PR:
Cache
, its methods and theMakeCache
function unexported.Cacher
interface, because it allows us to freely refactor theCache
implementation (like removing use of context and adding Release method, which you did in this PR).Originally posted by @manoranjith in #276 (comment)
The text was updated successfully, but these errors were encountered: