You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
More recent commits use a newer signer (capable of signing post EIP-155 and post London Fork transactions. Depending on how the transactions are created this may break the Transactor in wallet/hd/transactor.go.
Proposal
Option 1: Get rid of the hdwallet dependency, since it seems to be no longer maintained.
Option 2: Update to a later commit and fix Transactor such that transactions without a ChainId can still be signed, thus allowing replay protected transactions through EIP-155.
Option 3: Leave it as it is. This option has the least amount of effort needed, but does not protect against replaying transactions on a different Ethereum chain/testnet.
The text was updated successfully, but these errors were encountered:
Problem
We currently have the dependency
github.com/miguelmota/go-ethereum-hdwallet v0.1.1
(https://github.com/miguelmota/go-ethereum-hdwallet), which:More recent commits use a newer signer (capable of signing post EIP-155 and post London Fork transactions. Depending on how the transactions are created this may break the Transactor in
wallet/hd/transactor.go
.Proposal
Option 1: Get rid of the hdwallet dependency, since it seems to be no longer maintained.
Option 2: Update to a later commit and fix Transactor such that transactions without a ChainId can still be signed, thus allowing replay protected transactions through EIP-155.
Option 3: Leave it as it is. This option has the least amount of effort needed, but does not protect against replaying transactions on a different Ethereum chain/testnet.
The text was updated successfully, but these errors were encountered: