Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdwallet dependency #27

Open
DragonDev1906 opened this issue Aug 5, 2022 · 0 comments
Open

hdwallet dependency #27

DragonDev1906 opened this issue Aug 5, 2022 · 0 comments

Comments

@DragonDev1906
Copy link
Contributor

DragonDev1906 commented Aug 5, 2022

Problem

We currently have the dependency github.com/miguelmota/go-ethereum-hdwallet v0.1.1 (https://github.com/miguelmota/go-ethereum-hdwallet), which:

  • uses an old signer in its wallet implementation
  • was released in July 2021
  • had its last commit on July 4, 2022
  • and is archived on github (read-only)

More recent commits use a newer signer (capable of signing post EIP-155 and post London Fork transactions. Depending on how the transactions are created this may break the Transactor in wallet/hd/transactor.go.

Proposal

Option 1: Get rid of the hdwallet dependency, since it seems to be no longer maintained.

Option 2: Update to a later commit and fix Transactor such that transactions without a ChainId can still be signed, thus allowing replay protected transactions through EIP-155.

Option 3: Leave it as it is. This option has the least amount of effort needed, but does not protect against replaying transactions on a different Ethereum chain/testnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant