Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review code for use of expect()/unwrap()/panic!()/assert!() #196

Open
simongdavies opened this issue Jan 29, 2025 · 0 comments
Open

Review code for use of expect()/unwrap()/panic!()/assert!() #196

simongdavies opened this issue Jan 29, 2025 · 0 comments

Comments

@simongdavies
Copy link
Contributor

There are numerous places where we use either expect()/unwrap()/panic!()/assert!() we should review and remove these where possible as they will cause the host process to crash.

Consider adding the following clippy checks:

expect_used
panic
unwrap_used

We should also check for use of indexing like this function_call.parameters.clone().unwrap()[0].clone() without checking the number of items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants