[interrupt-handlers] adds exception handling to the hyperlight guest #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n handler - interrupt handler entry stubs = -- added macros to save/restore register context -- added defintions for different exceptions (_do_excp0-20+30), which save context, set params per SysV ABI, call handler, restore context, then iretq via macros. - added an exception handler that are used by the _do_excp* fxns. Note: this code is specific for x86_64 Signed-off-by: danbugs <[email protected]>
- added IdtEntry structure, - created IDT static mut array, and - made fxns to init_idt and set_idt_entry. Signed-off-by: danbugs <[email protected]>
- made Idtr structure (+ its static mut global var) to house the IDT, and - made load_idt fxn that uses global_asm's lidt to load the IDT. Signed-off-by: danbugs <[email protected]>
- added GdtEntry struct for GDT static mut global var, - added null, kernel code, and kernel data segments to GDT, - added code to load the GDT, and - added calls to init_idt, load_idt, and load_gdt to entrypoint. Signed-off-by: danbugs <[email protected]>
- added new guest fxn to simpleguest that triggers an invalid opcode exception - added test in guest_dispatch that calls the new guest fxn to test exception handling Signed-off-by: danbugs <[email protected]>
danbugs
force-pushed
the
danbugs/interrupt-handlers
branch
from
f441a46 to
918bc74
Compare
danbugs
changed the title
ludfjig
approved these changes
Feb 14, 2025
| generate_excp!(11), | ||
| generate_excp!(12), | ||
| generate_excp!(13), | ||
| generate_excp!(14, pagefault), |
There was a problem hiding this comment.
I believe more exception types than pagefault take additional parameters
| @@ -86,6 +89,14 @@ pub extern "win64" fn entrypoint(peb_address: u64, seed: u64, ops: u64, max_log_ | |||
| let peb_ptr = P_PEB.unwrap(); | |||
| __security_cookie = peb_address ^ seed; | |||
|
|
|||
| // Set up GDT/IDT | |||
| load_gdt(); | |||
| init_idt(); | |||
There was a problem hiding this comment.
question: does it make sense to distinguish init_idt from load_idt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces exception handling to the Hyperlight guest by setting up and loading a Global Descriptor Table (GDT) and an Interrupt Descriptor Table (IDT) onto the CPU.
GDT Setup & Loading
lgdt.IDT Setup & Exception Handlers
iretq.context_saveandcontext_restoreto properly preserve CPU state.lidt.This PR closes #228.