Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an issue for each summary workflow that has to be implemented #291

Closed
faricazjj opened this issue Jun 12, 2022 · 4 comments
Closed
Assignees

Comments

@faricazjj
Copy link
Collaborator

faricazjj commented Jun 12, 2022

I created issues for each broken down task based on @daneckaw 's list of things left to do for summary workflow:

  1. General:
    1.1 Decide on what to do with optional plots/things to be visualized outside of OEB. See discussion here: utils: scripts for visualizing summary statistics outside OEB #245 - might be low priority, but it would be helpful for the paper: feat(Publication): Plot outside of OpenEBench #290
    1.2 Do we need to change any metrics based on results we already have?
  2. Identification summary workflow :feat: identification summary workflow #239
  1. Quantification summary workflow - workflow and metrics calculation functions done
    3.1 Additional testing/debugging ongoing: Quantification summary workflow: testing #299
    3.2 Optional metrics/plots (as in specification). Depends on completing task 1.1
  2. Differential summary workflow: feat(Summary workflows): Differential summary workflow #294
    4.1 Workflow "backbone" - can be mostly copied from quantification, but input validation will be different: Differential summary workflow: backbone #292
    4.2 POC of metrics to be added: Differential summary workflow: metrics POC #293
    4.3 Implement Functions for calculating metrics (there is only one) - can be done independently of 4.1: Differential summary workflow: metrics implementation #295
    4.4 High level testing. Depends on completing tasks 4.1-4.2: Differential summary workflow: testing #296
    4.5 Adjust differential ranking: Adjust differential ranking #309

@daneckaw @dominikburri @mrgazzara let me know if there's anything I missed

@faricazjj faricazjj self-assigned this Jun 12, 2022
@dominikburri
Copy link
Collaborator

Hi @faricazjj , thank you for the breakdown!
@txellferret and I are also working on the ranking parameter for the OEB plots (i.e. that the right corner is set to better) in PR #262. It is for the quantification swf, but should then be passed down to other swfs as well, for details see issue #242.

@faricazjj
Copy link
Collaborator Author

@dominikburri I see! Thank you for pointing it out, I'll add adjust identification ranking and adjust differential ranking to the list! :D

@faricazjj faricazjj changed the title Create an issue for each summary workflow that has to be implemented. Cross check with project Metrics. Create an issue for each summary workflow that has to be implemented Jun 17, 2022
@faricazjj
Copy link
Collaborator Author

@dominikburri done! They're now under points 2.6 and 4.5

@faricazjj
Copy link
Collaborator Author

Closing this issue since all currently known summary workflow todos have issues created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants