Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversing typing order during animation breaks component #31

Open
rijkvanzanten opened this issue Sep 29, 2017 · 2 comments
Open

Reversing typing order during animation breaks component #31

rijkvanzanten opened this issue Sep 29, 2017 · 2 comments

Comments

@rijkvanzanten
Copy link

rijkvanzanten commented Sep 29, 2017

Version

0.4.1

Steps to reproduce

  1. Set typing prop to 1
  2. Change typing prop to -1 during the typing animation
  3. Set typing prop to 1 again after animation

Expected behavior

It should (1.) start typing, (2.) erase the currently typed, and (3.) start typing again

Actual behavior

The plugin sets the visibleChars value in state to a value 1 of from what is should be.
E.g., on erase, visibleChars should be -1, but if you change typing during the transition, it is set to -2. After that wrong value, it toggles between -2 and -1 instead of -1 and the length of the sentence.

@jacobdanovitch
Copy link

jacobdanovitch commented Jan 6, 2018

Still having this issue as well. Any chance anyone's found a solution?

@archieherbias
Copy link

I made a pull request for this issue.
#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants