Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPermissionState() is incorrect for [deny & don't ask again] #104

Closed
jacobras opened this issue Feb 29, 2024 · 1 comment · Fixed by #105
Closed

getPermissionState() is incorrect for [deny & don't ask again] #104

jacobras opened this issue Feb 29, 2024 · 1 comment · Fixed by #105
Assignees
@jacobras
Labels
bug Something isn't working
Milestone
0.18.0

Comments

@jacobras
Copy link
Contributor

jacobras commented Feb 29, 2024 •
edited
Loading

The method permissionController.getPermissionState() returns an incorrect state on Android when using [deny & don't ask again]:

  • The first time, getPermissionState() returns PermissionState.NotDetermined ✅
  • After [deny], getPermissionState() returns PermissionState.Denied ✅
  • After [deny & don't ask again], getPermissionState() returns PermissionState.NotDetermined ❌

⏩ The NotDetermined state is not always accurate on Android.

Reproduction code

Reproduction repository: https://github.com/jacobras/Moko-Permissions-Android-Bug

Screen capture

MokoPermissionStateBugAndroid
@jacobras jacobras mentioned this issue Feb 29, 2024
Merged
@Alex009 Alex009 linked a pull request Apr 11, 2024 that will close this issue
Add NotGranted to PermissionState for Android #105
Merged
@Alex009 Alex009 added this to the 0.18.0 milestone Apr 11, 2024
@Alex009 Alex009 added the bug Something isn't working label Apr 11, 2024
@Alex009
Copy link
Member

Alex009 commented Apr 15, 2024

will be released in 0.18.0

@Alex009 Alex009 closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobras jacobras

Labels
bug Something isn't working
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

Add NotGranted to PermissionState for Android jacobras/moko-permissions
2 participants
@jacobras @Alex009