Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to instantiate sockets for a certain namespace #7

Open
Rostyk opened this issue Jan 11, 2021 · 1 comment
Open

The ability to instantiate sockets for a certain namespace #7

Rostyk opened this issue Jan 11, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Rostyk
Copy link

Rostyk commented Jan 11, 2021

The swift and java sockets have the interfaces to create a socket for a certain namespace, called nsp in both native frameworks.
In android io.socket.client.manager -> public Socket socket(final String nsp, Options opts) and for swift SocketIO: SocketManager.swift -> open func socket(forNamespace nsp: String)
It would be tremendously helpful if we could expose it to kotlin multiplatform as for now the socket binds to default / name space. I wanted to submit the pull request but having issues with building the project locally and validating the pull request on my local machine.

As a a side note: Awesome work on this library!

@Alex009 Alex009 added the enhancement New feature or request label Jan 12, 2021
@Alex009
Copy link
Member

Alex009 commented Jan 12, 2021

thx for report! we not use in our project namespace anytime, but your pull request will be good :)
can you describe what problems you have with building project locally? now configuration support very simple dev start - git clone and gradle build will success without any additional actions.

maybe not all environment available? jdk 1.8, android-sdk, xcode cli tools?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants