Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to call Argo scripts with Quest query object #453

Closed
zachghiaccio opened this issue Oct 6, 2023 · 2 comments
Closed

Unable to call Argo scripts with Quest query object #453

zachghiaccio opened this issue Oct 6, 2023 · 2 comments

Comments

@zachghiaccio
Copy link
Contributor

This issue was found while working on the argo branch.

I'm working on an example notebook to showcase the QUEST functionality, but I am having a hard time accessing the scripts needed to query Argo data. I am able to access the scripts and do an Argo search with the following import statements:

import icepyx as ipx
from icepyx.core.spatial import geodataframe
from icepyx.quest.dataset_scripts.dataset import DataSet
from icepyx.quest.dataset_scripts.argo import Argo

However, when attempting to access Argo (and ICESat-2) data through the following import:

from icepyx import Quest

I am having a tough time finding a querying function for Argo. I see there is a Quest().add_icesat2() feature, and there is a similar function for Argo in test_quest.py (Line 35), but it does not seem to be implemented.

@JessicaS11
Copy link
Member

Hey @zachghiaccio! We implemented this functionality in #441 but commented it out so that the tests would pass (because the argo.py script the functions in quest.py called wasn't actually available yet in that PR). I've uncommented the Quest.add_argo() pieces (and related tests) in the argo branch (#427). Let me know if that doesn't resolve this (note that kwargs won't be accepted until we merge #452).

@zachghiaccio
Copy link
Contributor Author

Looks like that did the job, thanks! I can start making the workbook and testing the code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants