Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce surface types for surfaces #653

Open
MicahGale opened this issue Feb 3, 2025 · 0 comments
Open

Enforce surface types for surfaces #653

MicahGale opened this issue Feb 3, 2025 · 0 comments
Labels
feature request An issue that improves the user interface.

Comments

@MicahGale
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When setting the surface type for a concrete surface object you can accidentally set the wrong surface type.

For example:

In [2]: cyl = montepy.surfaces.cylinder_on_axis.CylinderOnAxis()

In [6]: cyl.surface_type = montepy.surfaces.surface_type.SurfaceType.PZ

raises no error.

Describe the solution you'd like

When setting a surface type a sanity check should be done and some sort of ValueError raised.

Describe alternatives you've considered
This could also be done with validate, but I think that's too late.

Additional context
This was started with looking into #646.

@MicahGale MicahGale added the feature request An issue that improves the user interface. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request An issue that improves the user interface.
Projects
None yet
Development

No branches or pull requests

1 participant