We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe.
When setting the surface type for a concrete surface object you can accidentally set the wrong surface type.
For example:
In [2]: cyl = montepy.surfaces.cylinder_on_axis.CylinderOnAxis() In [6]: cyl.surface_type = montepy.surfaces.surface_type.SurfaceType.PZ
raises no error.
Describe the solution you'd like
When setting a surface type a sanity check should be done and some sort of ValueError raised.
ValueError
Describe alternatives you've considered This could also be done with validate, but I think that's too late.
validate
Additional context This was started with looking into #646.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Is your feature request related to a problem? Please describe.
When setting the surface type for a concrete surface object you can accidentally set the wrong surface type.
For example:
raises no error.
Describe the solution you'd like
When setting a surface type a sanity check should be done and some sort of
ValueError
raised.Describe alternatives you've considered
This could also be done with
validate
, but I think that's too late.Additional context
This was started with looking into #646.
The text was updated successfully, but these errors were encountered: