You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good suggestion to include the exceptions. I don't know whether anyone is actually using this package still, but I do want the isArea() function to return mostly correct results.
but I do want the isArea() function to return mostly correct results.
I wonder if this should be split up in a "isConsideredArea" (the part from iD) and "canBeMappedAsArea" (the part from this library which relies on the tagging schema).
There are a few exceptions which describe area features but are not covered by presets. They are hard coded at https://github.com/openstreetmap/iD/pull/10278/files#diff-02f586096655a2fa6acaba20cb00a885b0594767d860e7cab713bc8e9d00d95dL42-L68 ATM.
It might be worth extracting those to a shared place or maybe expand this package to hold them so all iD-like editors can use them.
The same goes for the
osmRemoveLifecyclePrefix
helper (https://github.com/openstreetmap/iD/pull/10278/files#diff-02f586096655a2fa6acaba20cb00a885b0594767d860e7cab713bc8e9d00d95dL78) which would also be a good addition to this package.The text was updated successfully, but these errors were encountered: