Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id editor osmAreaKeysExceptions to the list #158

Open
tordans opened this issue Jun 11, 2024 · 2 comments
Open

Add id editor osmAreaKeysExceptions to the list #158

tordans opened this issue Jun 11, 2024 · 2 comments

Comments

@tordans
Copy link

tordans commented Jun 11, 2024

There are a few exceptions which describe area features but are not covered by presets. They are hard coded at https://github.com/openstreetmap/iD/pull/10278/files#diff-02f586096655a2fa6acaba20cb00a885b0594767d860e7cab713bc8e9d00d95dL42-L68 ATM.

It might be worth extracting those to a shared place or maybe expand this package to hold them so all iD-like editors can use them.

The same goes for the osmRemoveLifecyclePrefix helper (https://github.com/openstreetmap/iD/pull/10278/files#diff-02f586096655a2fa6acaba20cb00a885b0594767d860e7cab713bc8e9d00d95dL78) which would also be a good addition to this package.

@bhousel
Copy link
Contributor

bhousel commented Jun 15, 2024

Good suggestion to include the exceptions. I don't know whether anyone is actually using this package still, but I do want the isArea() function to return mostly correct results.

@tordans
Copy link
Author

tordans commented Jun 15, 2024

I don't know whether anyone is actually using this package still

I only noticed it due to its use in the real-changesets-parser which part of the core of osmcha. But the Dependents view lists a few other repos and packages (with OSMCha having the most stars)

but I do want the isArea() function to return mostly correct results.

I wonder if this should be split up in a "isConsideredArea" (the part from iD) and "canBeMappedAsArea" (the part from this library which relies on the tagging schema).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants