Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch>=2.4 dependency in dev means no support for Intel Macs #112

Closed
ajkessel opened this issue Oct 22, 2024 · 2 comments · Fixed by #113
Closed

torch>=2.4 dependency in dev means no support for Intel Macs #112

ajkessel opened this issue Oct 22, 2024 · 2 comments · Fixed by #113
Assignees
Labels
bug Something isn't working

Comments

@ajkessel
Copy link

Describe the bug

torch stopped building for Intel Macs after 2.2.2. coqui-tts main branch still installs because it only requires torch>=2.1, but on dev you are requiring torch>=2.4, and thus it cannot be installed even on a relatively recent Mac (e.g. iMac (Retina 5K, 27-inch, 2020)). Do you need the >=2.4 requirement or could it be loosened?

To Reproduce

Attempt to install from dev

Expected behavior

No response

Logs

No response

Environment

{
    "CUDA": {
        "GPU": [],
        "available": false,
        "version": null
    },
    "Packages": {
        "PyTorch_debug": false,
        "PyTorch_version": "2.2.2",
        "TTS": "0.24.2",
        "numpy": "1.26.4"
    },
    "System": {
        "OS": "Darwin",
        "architecture": [
            "64bit",
            ""
        ],
        "processor": "i386",
        "python": "3.11.10",
        "version": "Darwin Kernel Version 24.0.0: Tue Sep 24 23:36:30 PDT 2024; root:xnu-11215.1.12~1/RELEASE_X86_64"
    }
}

Additional context

No response

@ajkessel ajkessel added the bug Something isn't working label Oct 22, 2024
@eginhard eginhard self-assigned this Oct 23, 2024
@eginhard
Copy link
Member

eginhard commented Oct 23, 2024

Yeah, I agree it's not ideal. I've started adding some conditional handling for the code that needed this in idiap/coqui-ai-Trainer#11, after which I can do the same in this repo (#113) and go back down to 2.1

@eginhard
Copy link
Member

eginhard commented Nov 5, 2024

The minimum Pytorch version is now back to 2.1 (2.3 if using Python 3.12).

@eginhard eginhard closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants