Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCR's WGLC review (the nits) #47

Open
thomas-fossati opened this issue Jan 23, 2025 · 0 comments
Open

MCR's WGLC review (the nits) #47

thomas-fossati opened this issue Jan 23, 2025 · 0 comments
Labels
wglc working group last call

Comments

@thomas-fossati
Copy link
Collaborator

Archived-at: https://mailarchive.ietf.org/arch/msg/rats/2QO5c4m6lq7HvEjBiccQy8-JakM/

nits:

I found 2. Actual State vs Reference State could be more clear about
Actual/Reference being things.  I suggest that maybe paragraph 3 and 4 could
either be subsections, or maybe definition list if you prefer.

Also:
        That is, where actual state has a single value per claim per Target
        Environment applying to one device at one point in time, reference
        state can have a set of values per claim per Target Environment.

I found this single sentence to be too much.
Could it be reworded into two sentences?  Perhaps

        A reference state can have a set of values per claim per Target
        Environment.  This is contrasted with actual state, which has a
        single value per claim per Target Environment.
        Actual states apply to one device at one point in time.

Figure 1 has this anomaly of actual state layer-0 being an Endorsement vs
Evidence.  This is explained two paragraphs layer.  I wonder if that
paragraph could be earlier?

section 4:
s/While this is typical, cryptography other than public key may also be
        used./
 /While use of public key cryptography is typical for a verification key,
        cryptography other than public key may also be used./

Questions like that given in paragraph 4 of section 4, about a certificate
that passes up to a trusted root, or... that belongs in Protocol
documentation ought to be collected into a section or appendix.

The 'sometimes' is used twice. Not sure it should even be used once :-)
Also: "Some implementations..", and to me these read like SHOULDs that
haven't had their exceptions explained.
I recognize the authors are trying to be inclusive of many views, but it
might be better to just be opininated, and make the exceptions more clearly
articulated.
@thomas-fossati thomas-fossati added the wglc working group last call label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wglc working group last call
Projects
None yet
Development

No branches or pull requests

1 participant