Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: improve simulation targets for scaffolded apps #2753

Closed
Tracked by #3051
aljo242 opened this issue Aug 15, 2022 · 1 comment
Closed
Tracked by #3051

templates: improve simulation targets for scaffolded apps #2753

aljo242 opened this issue Aug 15, 2022 · 1 comment
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding. type:testing
Milestone

Comments

@aljo242
Copy link
Contributor

aljo242 commented Aug 15, 2022

Currently ignite chain simulate runs a very basic simulation test for chains, calling the basic BenchmarkSimulation() test, which creates a simulation test that runs a number of randomized state transitions and will fail of the app panics.

There are many other simulation targets and tests that could be added as seen here, namely a TestAppStateDeterminism() target. This specific test runs the simulation with the same random seed multiple times and checks the resulting AppHash against other runs to verify that the state of the app is being deterministically set. Non-determinism is one of the largest issues devs (especially new ones) face when starting with blockchain development. This test could be a really useful target to eliminate these issues for devs.

If we want to keep the command simplified (i.e. just calling ignite chain simulate) I think we should replace BenchmarkSimulation with TestAppStateDeterminism as the this covers everything BenchmarkSimulation covers plus non-determinism.

Additionally, we could expose multiple simulation targets if we want to make the command a bit more complex.

@aljo242 aljo242 added type:testing type:request Feature request. component:scaffold Feature, enhancement, or refactor related to scaffolding. labels Aug 15, 2022
@fadeev fadeev removed the type:request Feature request. label Sep 17, 2022
@aljo242 aljo242 added this to the v0.27.0 milestone Dec 16, 2022
@julienrbrt
Copy link
Member

This has been improved in #4463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding. type:testing
Projects
None yet
Development

No branches or pull requests

3 participants