From 080a0bf0ac4051e0b2339a8ddadb78e5331ff7dd Mon Sep 17 00:00:00 2001 From: turner Date: Thu, 30 Jan 2025 15:49:07 -0500 Subject: [PATCH] Constrain track height setting --- js/ui/menuUtils.js | 50 ++++++++++++++++++++++++---------------------- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/js/ui/menuUtils.js b/js/ui/menuUtils.js index f2e29b276..54630bc17 100644 --- a/js/ui/menuUtils.js +++ b/js/ui/menuUtils.js @@ -290,38 +290,40 @@ function trackHeightMenuItem() { const callback = () => { - const number = parseInt(this.browser.inputDialog.value, 10); + if (this.browser.inputDialog.value !== undefined) { - if (undefined !== number) { + const number = parseInt(this.browser.inputDialog.value, 10) - const tracks = []; - if (this.trackView.track.selected) { - tracks.push(...(this.trackView.browser.getSelectedTrackViews().map(({track}) => track))); - } else { - tracks.push(this); - } - - for (const track of tracks) { - // Explicitly setting track height turns off autoHeight - track.trackView.autoHeight = false; + if (number > 0){ - // If explicitly setting the height adjust min or max, if necessary - if (track.minHeight !== undefined && track.minHeight > number) { - track.minHeight = number; - } - if (track.maxHeight !== undefined && track.maxHeight < number) { - track.minHeight = number; + const tracks = []; + if (this.trackView.track.selected) { + tracks.push(...(this.trackView.browser.getSelectedTrackViews().map(({track}) => track))); + } else { + tracks.push(this); } - track.trackView.setTrackHeight(number, true); - track.trackView.checkContentHeight(); - track.trackView.repaintViews(); + for (const track of tracks) { + // Explicitly setting track height turns off autoHeight + track.trackView.autoHeight = false; - } // for (tracks) + // If explicitly setting the height adjust min or max, if necessary + if (track.minHeight !== undefined && track.minHeight > number) { + track.minHeight = number; + } + if (track.maxHeight !== undefined && track.maxHeight < number) { + track.minHeight = number; + } + track.trackView.setTrackHeight(number, true); - } // if (undefined !== number) + track.trackView.checkContentHeight(); + track.trackView.repaintViews(); + } // for (tracks) - }; // callback + } // if () + + } // if () + } const config = {