From f0aac9c90f6a7ce3557bc583a4b3b3bbb822160f Mon Sep 17 00:00:00 2001
From: Jerome Haltom <jhaltom@alethic.solutions>
Date: Sun, 18 Feb 2024 11:27:10 -0600
Subject: [PATCH] Remove design time buld from sub targets. Lets see if this
 clears up some issues.

---
 .../MatchCompatibleRuntimeIdentifierItemsTests.cs             | 2 +-
 src/IKVM.Core.MSBuild/targets/IncludeProjectReference.targets | 4 ++--
 src/IKVM.Core.MSBuild/targets/PackageProjectReference.targets | 4 ++--
 src/IKVM.Core.MSBuild/targets/PublishProjectReference.targets | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/IKVM.Core.MSBuild.Tasks.Test/MatchCompatibleRuntimeIdentifierItemsTests.cs b/src/IKVM.Core.MSBuild.Tasks.Test/MatchCompatibleRuntimeIdentifierItemsTests.cs
index 1d4f615..c018441 100644
--- a/src/IKVM.Core.MSBuild.Tasks.Test/MatchCompatibleRuntimeIdentifierItemsTests.cs
+++ b/src/IKVM.Core.MSBuild.Tasks.Test/MatchCompatibleRuntimeIdentifierItemsTests.cs
@@ -113,7 +113,7 @@ public void ShouldMatchManyItemsWithCompatibleParent()
         public void ShouldMatchSingleItemWithCompatibleChild()
         {
             var t = new MatchCompatibleRuntimeIdentifierItems();
-            t.TargetRuntimeIdentifiers = "win-x86";
+            t.TargetRuntimeIdentifiers = "win-x86;win-x64";
             t.Items = new[]
             {
                 new TaskItem("itemA", new Dictionary<string,string>()
diff --git a/src/IKVM.Core.MSBuild/targets/IncludeProjectReference.targets b/src/IKVM.Core.MSBuild/targets/IncludeProjectReference.targets
index 840c24a..9441bdb 100644
--- a/src/IKVM.Core.MSBuild/targets/IncludeProjectReference.targets
+++ b/src/IKVM.Core.MSBuild/targets/IncludeProjectReference.targets
@@ -45,8 +45,8 @@
                 <Properties>%(_IncludeProjectReference.SetConfiguration);%(_IncludeProjectReference.SetPlatform);%(_IncludeProjectReference.SetTargetFramework)</Properties>
             </_IncludeProjectReferencesToTarget>
         </ItemGroup>
-        <MSBuild Projects="@(_IncludeProjectReferencesToTarget)" Targets="Build" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);RuntimeIdentifier" />
-        <MSBuild Projects="@(_IncludeProjectReferencesToTarget)" Targets="BuiltProjectOutputGroup" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);RuntimeIdentifier" RebaseOutputs="true">
+        <MSBuild Projects="@(_IncludeProjectReferencesToTarget)" Targets="Build" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);RuntimeIdentifier;DesignTimeBuild" />
+        <MSBuild Projects="@(_IncludeProjectReferencesToTarget)" Targets="BuiltProjectOutputGroup" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);RuntimeIdentifier;DesignTimeBuild" RebaseOutputs="true">
             <Output TaskParameter="TargetOutputs" ItemName="_ResolvedIncludeProjectReferenceItems" />
         </MSBuild>
         <ItemGroup>
diff --git a/src/IKVM.Core.MSBuild/targets/PackageProjectReference.targets b/src/IKVM.Core.MSBuild/targets/PackageProjectReference.targets
index 469bd27..bd54628 100644
--- a/src/IKVM.Core.MSBuild/targets/PackageProjectReference.targets
+++ b/src/IKVM.Core.MSBuild/targets/PackageProjectReference.targets
@@ -46,8 +46,8 @@
                 <Properties>%(_PackageProjectReference.SetConfiguration);%(_PackageProjectReference.SetPlatform)</Properties>
             </_PackageProjectReferencesToTarget>
         </ItemGroup>
-        <MSBuild Projects="@(_PackageProjectReferencesToTarget)" Targets="Build" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);TargetFramework;RuntimeIdentifier" />
-        <MSBuild Projects="@(_PackageProjectReferencesToTarget)" Targets="_CleanPackageFiles;Pack;GetPackageOutputPath" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);TargetFramework;RuntimeIdentifier" RebaseOutputs="true">
+        <MSBuild Projects="@(_PackageProjectReferencesToTarget)" Targets="Build" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);TargetFramework;RuntimeIdentifier;DesignTimeBuild" />
+        <MSBuild Projects="@(_PackageProjectReferencesToTarget)" Targets="_CleanPackageFiles;Pack;GetPackageOutputPath" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);TargetFramework;RuntimeIdentifier;DesignTimeBuild" RebaseOutputs="true">
             <Output TaskParameter="TargetOutputs" ItemName="_ResolvedPackageOutputPath" />
         </MSBuild>
         <ItemGroup>
diff --git a/src/IKVM.Core.MSBuild/targets/PublishProjectReference.targets b/src/IKVM.Core.MSBuild/targets/PublishProjectReference.targets
index 79d959c..5175ddb 100644
--- a/src/IKVM.Core.MSBuild/targets/PublishProjectReference.targets
+++ b/src/IKVM.Core.MSBuild/targets/PublishProjectReference.targets
@@ -90,7 +90,7 @@
                 <Properties>%(_PublishProjectReference.SetConfiguration);%(_PublishProjectReference.SetPlatform);%(_PublishProjectReference.SetTargetFramework);%(_PublishProjectReference.SetRuntimeIdentifier)</Properties>
             </_PublishProjectReferencesToPublishTarget>
         </ItemGroup>
-        <MSBuild Projects="@(_PublishProjectReferencesToPublishTarget)" Targets="Publish;GetPublishProjectPath" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences)" RebaseOutputs="true">
+        <MSBuild Projects="@(_PublishProjectReferencesToPublishTarget)" Targets="Publish;GetPublishProjectPath" BuildInParallel="$(BuildInParallel)" RemoveProperties="$(_GlobalPropertiesToRemoveFromProjectReferences);DesignTimeBuild" RebaseOutputs="true">
             <Output TaskParameter="TargetOutputs" ItemName="__ResolvedPublishProjectReferencePublishProjectPath" />
         </MSBuild>
         <ItemGroup>