-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting Breaks with jQuery UI 1.13+ #138
Comments
Hi Fritz, I had the same issue as you, this seems to be broken in jquery ui, not in this tool. On line 16164 and 16165, replace those line: with: Hope this helps! |
Thanks Ruben!
I appreciate your help very much!
Fritz Green
918-213-5497
***@***.***
Bartlesville, OK
… On Feb 9, 2022, at 2:39 PM, Ruben Schulz ***@***.***> wrote:
Hi Fritz,
I had the same issue as you, this seems to be broken in jquery ui, not in this tool.
I managed to fix this by changing 2 lines in the jquery-ui.js file:
On line 16164 and 16165, replace those line:
verticalDirection = this.dragDirection.vertical;
horizontalDirection = this.dragDirection.horizontal;
with:
verticalDirection = this._getDragVerticalDirection();
horizontalDirection = this._getDragHorizontalDirection();
Hope this helps!
—
Reply to this email directly, view it on GitHub <#138 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2OR6EGG3UFKBVXO6XMBSTU2LGHRANCNFSM5M6WXTBA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.
|
This is fixed in 2.1a version of current library: Changing in jquery-ui as suggested in above comments is not required. @FritzTGreen Please release it in a new tag as also requested in #141 |
- newer version breaks nestedSortable ilikenwf/nestedSortable#138 - this can be fixed by changing nestedSortable to https://github.com/ilikenwf/nestedSortable after they release newer version than 2.0.0
- newer version breaks nestedSortable ilikenwf/nestedSortable#138 - this can be fixed by changing nestedSortable to https://github.com/ilikenwf/nestedSortable after they release newer version than 2.0.0
- newer version breaks nestedSortable ilikenwf/nestedSortable#138 - this can be fixed by changing nestedSortable to https://github.com/ilikenwf/nestedSortable after they release newer version than 2.0.0
@rubenschulz Thank you for posting that fix. Dealing with that exact issue right now! |
This closed issue in the jQuery UI repository confirms and describes the issue.
Essentially, if using jQuery UI 1.13 or higher, attempting to drag an item in a nested sortable list freezes the list.
This issue does not happen with jQuery UI 1.12.
Is anybody maintaining a fork in which this issue has been resolved?
Thanks!
Fritz
The text was updated successfully, but these errors were encountered: