Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateOutputFFTMethods requires a image creator that can take an ImgFactory #650

Open
gselzer opened this issue Jan 27, 2023 · 1 comment
Assignees
Labels

Comments

@gselzer
Copy link
Contributor

gselzer commented Jan 27, 2023

As described in this forum post, CreateOutputFFTMethods will fail when it is asked to create a large image, as it always assumes that the image can be an ArrayImg.

We need an Op that can take an ImgFactory as a parameter, so that CreateOutputFFTMethods can decide whether to make a CellImg or an ArrayImg. Or, at least, we can delegate the ImgFactory choice to Util.getSuitableImgFactory. And then CreateOutputFFTMethods needs to call it.

(And we should also make this change in ImageJ-Ops2 😁)

@gselzer gselzer added the bug label Jan 27, 2023
@gselzer gselzer self-assigned this Jan 27, 2023
@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/error-when-correlating-large-images-in-ops/75433/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants