Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting between xarray and dataset should preserve image name #198

Closed
ctrueden opened this issue May 1, 2022 · 2 comments · Fixed by #233
Closed

Converting between xarray and dataset should preserve image name #198

ctrueden opened this issue May 1, 2022 · 2 comments · Fixed by #233
Milestone

Comments

@ctrueden
Copy link
Member

ctrueden commented May 1, 2022

The name property of DataArray matches up with getName() of Dataset and ImgPlus.

@ctrueden ctrueden added this to the m1 milestone May 1, 2022
@thewtex
Copy link
Member

thewtex commented May 3, 2022

Hi Curtis! I also ran into this here: spatial-image/multiscale-spatial-image#23

Additional note -- it was helpful to convert getName() from a Java String object to a Python string with str so it could be serialized to Zarr:

# The DataArray name needs to be set
image_da.name = str(image.getName())

@ctrueden
Copy link
Member Author

ctrueden commented May 4, 2022

Thanks @thewtex. I commented on your PR. I also filed #200 here to cover the conversion issue leading to serialization woes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants