Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined Usage of SilenceGeneratorSink and FFmpegSink #10

Open
athphane opened this issue Apr 7, 2024 · 1 comment
Open

Combined Usage of SilenceGeneratorSink and FFmpegSink #10

athphane opened this issue Apr 7, 2024 · 1 comment

Comments

@athphane
Copy link

athphane commented Apr 7, 2024

I'm trying to use this little library of yours to do some audio recording. From my understanding, if the SilenceGeneratorSink is not used, it would write the incoming audio data right next to each other, and not "write" the "dead air" that is there in the conversations. Trying to make the recordings as natural as possible.

I've source dived SilveGeneratorSink and kinda figured it out. I uses 2 skins at the same time in a sense? Then I figured I need the FFmpegSink so that I can actually write out the audio file? But I couldn't figure out how to combine both the SilenceGeneratorSink and FFmpegSink to get this working.

Anyways, I'm here looking for a Hail Mary and ask you if you could provide an example on the usage, or guide me in the proper way to do it.

@imayhaveborkedit
Copy link
Owner

imayhaveborkedit commented Apr 8, 2024

The silence generator code is a bit bad and broken and needs to be rewritten. All it does is emit silence frames when its not receiving data otherwise. If you do use it, you compose it like so:

SilenceGeneratorSink(FFmpegSink(...))

No guarantees that it'll be accurate if it even works. You have been warned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants