-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure algorithms return something #44
Comments
Ah, good catch! I'm assuming you refer to the algorithms for both variants of |
I'm pretty sure that fix doesn't work as you sometimes terminate the set of steps early. |
Yes, I've noticed this and then started going through another spec to double-check - this is also how I was describing early termination in hit test module. Keeping the bug open until I fix this. |
I think I found the same issue in the main XR specification. Probably best not to copy-and-paste things too much 😉 |
Remove pose parameter from XRHitTestResult.createAnchor() API as it does not expand the capabilities of the API - applications can maintain fixed offsets relative to anchors themselves. Additionally, add missing returns into anchor creation algorithms in case they are supposed to early-exit (related to issue #44). Fixes #48.
Remove pose parameter from XRHitTestResult.createAnchor() API as it does not expand the capabilities of the API - applications can maintain fixed offsets relative to anchors themselves. Additionally, add missing returns into anchor creation algorithms in case they are supposed to early-exit (related to issue #44). Fixes #48.
I noticed a few times that algorithms were supposed to return something, e.g., a promise, but didn't.
It might help re-reading the algorithms and see if you could write an implementation from scratch given what's written down.
The text was updated successfully, but these errors were encountered: