Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure algorithms return something #44

Open
annevk opened this issue May 29, 2020 · 4 comments
Open

Ensure algorithms return something #44

annevk opened this issue May 29, 2020 · 4 comments

Comments

@annevk
Copy link

annevk commented May 29, 2020

I noticed a few times that algorithms were supposed to return something, e.g., a promise, but didn't.

It might help re-reading the algorithms and see if you could write an implementation from scratch given what's written down.

@bialpio
Copy link
Contributor

bialpio commented May 29, 2020

Ah, good catch! I'm assuming you refer to the algorithms for both variants of createAnchor(), I'll take a pass and make sure the algorithms should be possible to implement from scratch and that they align with prototype implementation that we have to reduce the risk of future compat issues.

@annevk
Copy link
Author

annevk commented May 30, 2020

I'm pretty sure that fix doesn't work as you sometimes terminate the set of steps early.

@bialpio
Copy link
Contributor

bialpio commented Jun 1, 2020

Yes, I've noticed this and then started going through another spec to double-check - this is also how I was describing early termination in hit test module. Keeping the bug open until I fix this.

@annevk
Copy link
Author

annevk commented Jun 2, 2020

I think I found the same issue in the main XR specification. Probably best not to copy-and-paste things too much 😉

bialpio added a commit that referenced this issue Jun 3, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Remove pose parameter from XRHitTestResult.createAnchor() API as it does not expand the capabilities of the API - applications can maintain fixed offsets relative to anchors themselves.

Additionally, add missing returns into anchor creation algorithms in case they are supposed to early-exit (related to issue #44).

Fixes #48.
bialpio added a commit that referenced this issue Jun 5, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Remove pose parameter from XRHitTestResult.createAnchor() API as it does not expand the capabilities of the API - applications can maintain fixed offsets relative to anchors themselves.

Additionally, add missing returns into anchor creation algorithms in case they are supposed to early-exit (related to issue #44).

Fixes #48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants