Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After opening an image from the folder view and reloading the page, navigation no longer works correctly #15222

Open
1 of 3 tasks
ayykamp opened this issue Jan 10, 2025 · 6 comments · May be fixed by #16492
Open
1 of 3 tasks

After opening an image from the folder view and reloading the page, navigation no longer works correctly #15222

ayykamp opened this issue Jan 10, 2025 · 6 comments · May be fixed by #16492
Assignees
@jinxuan-owyong
Labels
good first issue Good for newcomers 🖥️web

Comments

@ayykamp
Copy link
Contributor

ayykamp commented Jan 10, 2025 •
edited
Loading

The bug

After reloading the page, navigating back/forward results in the wrong image.

The OS that Immich Server is running on

Version of Immich Server

v1.142.2

Version of Immich Mobile App

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

-

Your .env content

-

Reproduction steps

  1. Open a folder
  2. Click on an image, opening it in full screen (e. g. the 5. image in the folder)
  3. Reload the page
  4. Use the arrows to navigate forward (now shows the 2. image in the folder) or backward (shows the 1. image)

Relevant log output

No response

Additional information

This works correctly in albums and the timeline.
@bo0tzz bo0tzz added good first issue Good for newcomers 🖥️web labels Jan 10, 2025
@alextran1502
Copy link
Contributor

Can you update to the latest version v1.124.2 and try again to see if you can reproduce this issue?

@ayykamp
Copy link
Contributor Author

ayykamp commented Jan 10, 2025

Sorry I'm already on v1.124.2 I just mistyped

@jinxuan-owyong
Copy link
Contributor

Would like to work on this issue :)

@yiningliu1 yiningliu1 mentioned this issue Feb 13, 2025
Open
8 tasks
@jinxuan-owyong
Copy link
Contributor

Hey @yiningliu1, it seems that you have the PR pointing to your own repo instead. The bug seems to be fixed 💯

@yiningliu1
Copy link

yiningliu1 commented Mar 2, 2025 •
edited
Loading

Hi @jinxuan-owyong , I created the PR before I realized that you had been assigned the issue and moved it to my own repo because I didn't want to "steal" it from you. Sorry for the confusion; I'm very new to open source and didn't know what the proper thing to do in this situation would be.

If you don't mind, I can change it to point to the main repo instead.

@jinxuan-owyong
Copy link
Contributor

@yiningliu1 Go ahead! No worries as I was stuck. Since you have already fixed it you should take the credit for it and we can avoid double the work.

@yiningliu1 yiningliu1 linked a pull request Mar 2, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinxuan-owyong jinxuan-owyong

Labels
good first issue Good for newcomers 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(web): folder view navigation refresh yiningliu1/immich
5 participants
@bo0tzz @alextran1502 @ayykamp @jinxuan-owyong @yiningliu1