Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guest user can add progress report #154

Open
tmfrnz opened this issue Mar 27, 2017 · 8 comments
Open

Guest user can add progress report #154

tmfrnz opened this issue Mar 27, 2017 · 8 comments
Assignees
@barancw @tmfrnz
Labels
in progress story:record story:reference (many-1) story

Comments

@tmfrnz
Copy link
Member

tmfrnz commented Mar 27, 2017 •
edited
Loading

As a guest user

I can contribute information in form of progress reports to any indicator. The user assigned to the indicator (or the user assigned to the human rights body?) will be notified about the submitted report. (see #274)
@tmfrnz
Copy link
Member Author

tmfrnz commented Mar 27, 2017

@ashbowe could you please clarify who should get notified:

  • the user assigned to the indicator the report is attached to, or
  • the users assigned to any associated human rights body (those that tag recommendations that are associated with actions that are associated with the indicator)?

@tmfrnz
Copy link
Member Author

tmfrnz commented Mar 27, 2017

@ashbowe it may be beneficial to require the user to create an account first (anyone can register and will be assigned the Guest role) - will discuss with Chris (@barancw)

@tmfrnz tmfrnz mentioned this issue Mar 27, 2017
Open
@ashbowe
Copy link

ashbowe commented Mar 27, 2017

Hi Timo, the second of those two options - the user who has overall responsibility for that set of recommendations

@tmfrnz
Copy link
Member Author

tmfrnz commented Mar 28, 2017

@ashbowe thank you for clarifying. Here some further thoughts:

In case an indicator is associated with an action associated with recommendations from different HR bodies (or an indicator is associated with multiple actions associated with recommendations from different HR bodies) more than one manager could be notified by email (as is also true with the planned email reminders)

Further if we are including SDGs, indicators associated with SDG targets, may not belong to any manager. In this case we may want to consider the option to disable public contribution for specific indicators (the SDG indicators) or assign users to SDGs as SDG managers.

@ashbowe
Copy link

ashbowe commented Mar 28, 2017

I think it would be great to have an SDG manager but having the option to disable contributions would also be helpful. Having these two options would allow for greatest flexibility so I'd be keen for that if possible and not too much trouble!

@tmfrnz
Copy link
Member Author

tmfrnz commented Sep 11, 2017 •
edited
Loading

Have included SDG managers, so also SDG indicators should now have a manager

@tmfrnz
Copy link
Member Author

tmfrnz commented Sep 12, 2017 •
edited
Loading

@barancw i have started implementing this on the client. For the server we would need the following changes:

1. Allow report creation for guest users (ASAP)

  • Allow a signed in guest to create (not update) a progress_report
  • Update test case
  • Force draft: true.

2. Notify category manager about report creation (not that urgent)

see #274

@tmfrnz tmfrnz removed the question label Sep 12, 2017
@tmfrnz tmfrnz added the ready label Sep 12, 2017
tmfrnz added a commit that referenced this issue Sep 14, 2017
@tmfrnz
allow any user to create progress report #154
bb687a6
tmfrnz added a commit to nmrf/sadata-server that referenced this issue Sep 14, 2017
@tmfrnz
Merge pull request #8 from impactoss/guest-report-154
f87500f 
allow any user to create progress report impactoss#154
tmfrnz added a commit that referenced this issue Sep 14, 2017
@tmfrnz
update report create policy #154
292e25d
tmfrnz added a commit to nmrf/sadata-server that referenced this issue Sep 14, 2017
@tmfrnz
Merge pull request #9 from impactoss/guest-report-154
e362cea 
update report create policy impactoss#154
tmfrnz added a commit that referenced this issue Sep 14, 2017
@tmfrnz
update test case to allow guest report creation #154
d581ab9
@tmfrnz
Copy link
Member Author

tmfrnz commented Sep 14, 2017

@barancw have managed to update policy and spec, only missing enforcement of draft state (true)

@tmfrnz tmfrnz self-assigned this Sep 14, 2017
@barancw barancw added in progress and removed ready labels Nov 1, 2017
parndt added a commit that referenced this issue Mar 14, 2018
@parndt
Allow contributors to create progress reports for indicators.
90a5543 
This was changed in bb687a6 for #154
so it makes sense to update the spec to allow for this because it will
otherwise just keep failing.
@parndt parndt mentioned this issue Mar 14, 2018
Merged
parndt pushed a commit that referenced this issue Jul 2, 2018
@tmfrnz
allow any user to create progress report #154
a3b42f1
parndt pushed a commit that referenced this issue Jul 2, 2018
@tmfrnz
update report create policy #154
80a77cb
parndt pushed a commit that referenced this issue Jul 2, 2018
@tmfrnz
update test case to allow guest report creation #154
813d56f
parndt added a commit that referenced this issue Jul 2, 2018
@parndt
Allow contributors to create progress reports for indicators.
bbc9bae 
This was changed in bb687a6 for #154
so it makes sense to update the spec to allow for this because it will
otherwise just keep failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barancw barancw

@tmfrnz tmfrnz

Labels
in progress story:record story:reference (many-1) story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@barancw @tmfrnz @ashbowe