Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics crate needs to be bumped to fix ahash compilation failure on Rust Nightly #90

Closed
fitzthum opened this issue Feb 12, 2024 · 2 comments
Closed

Metrics crate needs to be bumped to fix ahash compilation failure on Rust Nightly #90

fitzthum opened this issue Feb 12, 2024 · 2 comments

Comments

@fitzthum
Copy link
Contributor

See issue in ahash and fix in metrics that is not picked up here.
fitzthum added a commit to fitzthum/mobc that referenced this issue Feb 12, 2024
@fitzthum
chore: Update metrics to 0.22 (importcjj#90)
b9ce736 
Pick up fixes for ahash

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
fitzthum added a commit to fitzthum/mobc that referenced this issue Feb 12, 2024
@fitzthum
chore: Update metrics to 0.22.1 (importcjj#90)
9f6153f 
Pick up fixes for ahash.

Metrics has changed the usage of their macros, so
update to follow the new format.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
garrensmith pushed a commit that referenced this issue Feb 16, 2024
@fitzthum
chore: Update metrics to 0.22.1 (#90) (#91)
9ddf298 
Pick up fixes for ahash.

Metrics has changed the usage of their macros, so
update to follow the new format.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
@janeisklar
Copy link

Since the fix has been merged, do you have an ETA when there will be a new release that includes it? No pressure, just trying to figure out what to do with our failing CI:)

@garrensmith
Copy link
Collaborator

@janeisklar thanks for the reminder. New release is published #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garrensmith @janeisklar @fitzthum