Common ancestor rollup mode #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically a breaking change because clients need to update. However, until now no production client uses this function.
This also changes the return dictionary's structure of those function.
Aggregated geo score is the highest geo score of a node's children. Vision score is aggregated as is combined score.
… score of all leaves into common ancestor function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
The filtering steps necessary to calculate the
common_ancestorprediction are split between the JS side and native side.The native side does the initial filter step of using a cutoff of top score * 0.001 the remaining predictions are then sent to the JS side and filtered further. Having the filtering steps on the JS side required the native side to collect and aggregate additional information so that filtering can happen on the JS side.
For example, predictions needed to contain information about their ancestors which was added on iOS. Also geo scores and geo thresholds needed to be aggregated over all nodes, this was added on both Android and iOS.
On the JS side the predictions are sorted and passed through several filters to obtain the common ancestor, check for human, and return the top predictions.