Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading modified code #26

Open
priyankaray810 opened this issue Feb 7, 2021 · 6 comments
Open

Uploading modified code #26

priyankaray810 opened this issue Feb 7, 2021 · 6 comments

Comments

@priyankaray810
Copy link

After making the required changes in my repository(forked from the original repo), should I only generate the pull request?
@rexyagami
Copy link
Contributor

@priyankaray810 Yes

@priyankaray810
Copy link
Author

@rexyagami just now noticed that the name Alex Smith has got different spacings when I open it in different computer. is it a problem?

@rexyagami
Copy link
Contributor

@priyankaray810 maybe due to some font issue it is occuring

@priyankaray810
Copy link
Author

priyankaray810 commented Feb 7, 2021 •
edited
Loading

@rexyagami I have generated the pull request. can you please check if my modifications are correct?

@rexyagami
Copy link
Contributor

@piyushagarwal08 Sure

@rexyagami
Copy link
Contributor

Well done @priyankaray810 but there is some issue in the first name section when it comes to mobile view, other than that everything is fine, good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rexyagami @priyankaray810