You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comparing my concatenation changes with main reminded me that NodeCountMapper doesn't currently accumulate node counts from functions into the overall count. It should be given a map_function_definition method that does something similar to CallSiteCountMapper:
I wonder if the default map_function_definition implementation in CachedWalkMapper should be disabled, to avoid bugs like this? Maybe a default implementation could be provided in a separate method, e.g. _basic_map_function_definition, for convenience in mappers that don't need special behavior.
The text was updated successfully, but these errors were encountered:
Comparing my concatenation changes with
main
reminded me thatNodeCountMapper
doesn't currently accumulate node counts from functions into the overall count. It should be given amap_function_definition
method that does something similar toCallSiteCountMapper
:pytato/pytato/analysis/__init__.py
Lines 435 to 446 in 78b43c1
I wonder if the default
map_function_definition
implementation inCachedWalkMapper
should be disabled, to avoid bugs like this? Maybe a default implementation could be provided in a separate method, e.g._basic_map_function_definition
, for convenience in mappers that don't need special behavior.The text was updated successfully, but these errors were encountered: