Keypath variable in reactor is ignored in trace execution

[djpesic]

I am integrating another smart contract example in Atomkraft. I created a reactor stub (comments removed for clarity).

import logging
from typing import Dict

import pytest
from atomkraft.chain import Testnet
from modelator.pytest.decorators import step

keypath = "last_msg.name"


@pytest.fixture
def state():
    return {}

@step("store_cw_contract")
def store_cw_contract(testnet: Testnet, state: Dict, messages):
    logging.info("Step: store_cw_contract")

Variable keypath should override keypath argument inside
atomkraft test trace --trace traces/violation1.itf.json --reactor reactors/reactor.p
but it is not done. In order to use "keypath.name", I have to put in inside arguments like this
atomkraft test trace --trace traces/violation1.itf.json --reactor reactors/reactor.py --keypath "last_msg.name"

[ivan-gavran]

At the moment, we are setting the keypath variable at two places:
a) when generating the reactor
b) when running the test (atomkraft test trace ..).

In the case b), even if we don't set the option --keypath, it will still get set to the default value.

It seems to me that the right place for setting the keypath should be in reactor (which is a connector between the trace and the test).
@hvanz , what do you think?

[hvanz]

We should allow both, preferring the reactor first, with the option to override it with --keypath in the CLI. If both are empty, it should fail with a message. We should not provide a default value.