Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #40

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Fixed issue #40

merged 1 commit into from
Dec 24, 2023

Conversation

vandanafuletra
Copy link
Contributor

No description provided.

@vandanafuletra vandanafuletra merged commit e556ff6 into main Dec 24, 2023
1 check passed
@vandanafuletra
Copy link
Contributor Author

Raktbeej Code Review:

Summary:

Overall Summary:

  • The pull request includes changes to the UserController and the user.blade.php view.
  • It adds a new method getUserDetails to the UserController which retrieves user details.
  • It modifies the user.blade.php view to display the user details.

Issues & Action Items:

  • The check for "Missing authorization in request" is violated in UserController.php. Add an authorize method to validate user authorization.

    • File: UserController.php
    • Violating policy: Missing authorization in request
    • Line: 10
  • The check for "Check for Validation in controller" is violated in UserController.php. Move the validation logic to a separate Request class.

    • File: UserController.php
    • Violating policy: Check for Validation in controller
    • Line: 12
  • The check for "Check for Missing ENV variable" is violated in config/app.php. Add the new key to the .env.example file.

    • File: config/app.php
    • Violating policy: Check for Missing ENV variable
    • Line: 26
  • The check for "Check for env() call outside of config files" is violated in config/cache.php. Move the env() call to a config file.

    • File: config/cache.php
    • Violating policy: Check for env() call outside of config files
    • Line: 18

APPROVE / DISAPPROVE this PR:

This pull request cannot be approved as it violates some of the mentioned policies. Please fix the mentioned issues and raise another pull request.

Action Items:

  • Add an authorize method to UserController.php to validate user authorization. (Line: 10)
  • Move the validation logic in UserController.php to a separate Request class. (Line: 12)
  • Add the new key in config/app.php to the .env.example file. (Line: 26)
  • Move the env() call from config/cache.php to a config file. (Line: 18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant