Bring back class map #205
Open
Bring back class map #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neu2o
force-pushed
the
bring-back-class-map
branch
from
11820e4 to
b6647c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, at least with Haxe 4.1.5, openfl.Dictionary always compiles to UtilsObjectMap for Class. This is because UtilsObjectMap uses openfl.Object as key type and this is an abstract over Dynamic. That way at the moment Class matches openfl.Object and so it generates UtilsObjectMap instead of ClassMap. By swapping the order I give Class precedence over openfl.Object, so it generates ClassMap again, which I believe is correct.
I also added fromEnumValueMap as openfl.Dictionary already has toEnumValueMap and this was the only missing pair.Removed fromEnumValueMap again as Haxe Map also doesn't have it: https://github.com/HaxeFoundation/haxe/blob/4.1.4/std/haxe/ds/Map.hx