Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] 새로운 API 우선 구현 - V3 모듈 작업 #136

Open
4 of 5 tasks
sichoi42 opened this issue Oct 28, 2022 · 1 comment
Open
4 of 5 tasks

[Draft] 새로운 API 우선 구현 - V3 모듈 작업 #136

sichoi42 opened this issue Oct 28, 2022 · 1 comment
Assignees
@joohongpark @aseungbo @Oris482 @HyeonsikBae @eunbi9n @sichoi42 @gyutato
Labels
Backend front-end

Comments

@sichoi42
Copy link
Collaborator

sichoi42 commented Oct 28, 2022 •
edited
Loading

📝 DESCRIPTION
기존 기능을 유지한 상태로 새로운 API를 구현하기 위해 main에서 했던 것처럼
v3 모듈을 만들고 각 API 별로v3 prefix를 붙히도록 하겠습니다.
다들 API 구현을 하실 때 이 이슈로 만들어지는 be_v3/common 브랜치로부터 새로 브랜치를 파시기 바랍니다!

또한 프론트에서 새로 구현되는 API에 대해 request를 날릴 때는 endpoint에 v3를 붙혀서 요청하시기 바랍니다. ex) /v3/api/cabinet/count/floor

☑ TODO

  • V3 모듈 만들기
  • V3 모듈에 Cabinet 모듈 구현하기
  • V3 모듈에 return 모듈 구현하기
  • V3 모듈에 search 모듈 구현하기
  • V3 모듈에 user 모듈 구현하기
sichoi42 added a commit that referenced this issue Oct 28, 2022
@sichoi42
✨ add v3 module for new API #136
2df7f60 
add v3 module for new API #136
@sichoi42
Copy link
Collaborator Author

v3 prefix의 위치가 변경되었습니다.
ex) /api/v3/cabinet/count/floor

sichoi42 added a commit that referenced this issue Oct 28, 2022
@sichoi42
💄 lint check #136
9604aa8 
lint check #136
sichoi42 added a commit that referenced this issue Nov 5, 2022
@sichoi42
📦 add transactional setting code #136
e62303d 
add transactional setting code #136
sichoi42 added a commit that referenced this issue Nov 5, 2022
@sichoi42
🔨 update package.json #136
952d434 
update package.json #136
sichoi42 added a commit that referenced this issue Nov 5, 2022
@sichoi42
Merge pull request #150 from innovationacademy-kr/be_v3/common
fe8fb44 
📦 add transactional setting code #136
sichoi42 added a commit that referenced this issue Nov 7, 2022
@sichoi42
🐛 searchByBrokenCabinet 함수에서 BROKEN cabinet이 아닌 BANNED cabinet이 가져와지는…
597823c 
… 버그 수정 #136

searchByBrokenCabinet 함수에서 BROKEN cabinet이 아닌 BANNED cabinet이 가져와지는 버그 수정 #136
@sichoi42 sichoi42 mentioned this issue Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joohongpark joohongpark

@aseungbo aseungbo

@Oris482 Oris482

@HyeonsikBae HyeonsikBae

@eunbi9n eunbi9n

@sichoi42 sichoi42

@gyutato gyutato

Labels
Backend front-end
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

be_v3/common innovationacademy-kr/42cabi_admin
7 participants
@joohongpark @aseungbo @Oris482 @HyeonsikBae @eunbi9n @sichoi42 @gyutato