New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

233 remove duplicated buttons from `verbatim_popup` #234

Draft

m7pr wants to merge 1 commit into main from 233_duplicated_buttons_verbatim_popup@main

Contributor

m7pr commented Mar 13, 2024

Closes #233

This PR removes duplicated buttons for verbatim_popup that is used by Show R Code and Show Session Info. Not verbatim_popup looks like this

library(shiny)
ui <- fluidPage(verbatim_popup_ui("my_id", button_label = "Open popup"))
srv <- function(input, output) {
  verbatim_popup_srv(
    "my_id",
    "if (TRUE) { print('Popups are the best') }",
    title = "My custom title",
    style = TRUE
  )
}
if (interactive()) shinyApp(ui, srv)

And also Show R Code and Show Session Info modal do not contain duplicated Copy to Clipboard and Dismiss buttons.


          remove duplicated buttons from verbatim_popup

4f1ee7d

m7pr added the core label

m7pr mentioned this pull request

[Bug]: verbatim_popup has duplicated buttons #233

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core