Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: showing advance customization option for download format #235

Open
3 tasks done
kartikeyakirar opened this issue Mar 15, 2024 · 2 comments
Open
3 tasks done
Labels
core enhancement New feature or request

Comments

@kartikeyakirar
Copy link
Contributor

Feature description

Following the discussion in insightsengineering/teal.reporter#258, theplot_with_settingsand table_with_settings modules have been highlighted for their ability to allow users to download plots and tables in various formats. However, there is an expressed need for a feature that lets users customize these download formats. This enhancement request stems from an attempt by @Melkiades to save a PDF without pagination, which resulted in the table being truncated in the PDF file.

The proposed options for customization that could be exposed to users are as follows:

For table_with_settings:

PDF (export_as_pdf) options:

Orientation (Portrait/Landscape)
Page Width (pg_width)
Page Height (pg_height)
Margins
Minimum Siblings (min_siblings)
Font Family (font_family)
Font Size (font_size)
Characters Per Pica (cpp)
Maximum Width (max_width)
Column Widths (colwidths)

Text (export_as_txt) options:

Orientation (Landscape)
Page Width (pg_width)
Page Height (pg_height) is determined by page_dim(page_type) based on orientation.
Font Family (font_family)
Font Size (font_size)
Line Height (lineheight)
Characters Per Pica (cpp)
Maximum Width (max_width)
Column Widths (colwidths)
Page Break (page_break)

For plot_with_settings:

grDevices options for PDF, PNG, and SVG formats.
These enhancements aim to improve user experience by providing more flexibility in how plots and tables are downloaded and customized.

Suggested UI changes.
image

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@kartikeyakirar kartikeyakirar added enhancement New feature or request core labels Mar 15, 2024
@Melkiades
Copy link
Contributor

Thanks Kartik for working on this!! I think we should also add docx export ;)

@kartikeyakirar
Copy link
Contributor Author

@Melkiades I have added seprate task for this #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants