Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing IDs in the download part of plot-with-settings #255

Open
pawelru opened this issue Aug 5, 2024 · 0 comments
Open

Confusing IDs in the download part of plot-with-settings #255

pawelru opened this issue Aug 5, 2024 · 0 comments
Labels

Comments

@pawelru
Copy link
Contributor

pawelru commented Aug 5, 2024

In addition to #241

I have found confusing the approach of giving the IDs to the elements. Please find a few examples below:

  • #plot_with_settings-downbutton-downl

    • Why to put "download" twice?
    • Why two distinct shortcuts for the "download" - here: "down" and "downl".
    • Why to put the class "button" in the element ID?
  • #plot_with_settings-downbutton-data_download

    • (all of above)
    • it downloads the plot and it has nothing with the data
@donyunardi donyunardi added the core label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants