Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type returned from marl_eval.plotting_tools.plotting.probability_of_improvement #60

Open
liamclarkza opened this issue Mar 14, 2024 · 1 comment

Comments

@liamclarkza
Copy link
Collaborator

The function marl_eval.plotting_tools.plotting.probability_of_improvement(...) is defined to return a Matplotlib Figure but actually returns an Axes.

We can either update the type definition or modify the function to return the handle to the Figure. I think the latter is a better option. Happy to put in a PR for either.

@liamclarkza
Copy link
Collaborator Author

Same issue also exists for marl_eval.plotting_tools.plotting.sample_efficiency_curves and marl_eval.plotting_tools.plotting.plot_single_task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant