-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slack] Read message cross channels #1110
Comments
Hello @ShihChun-H, I'm interested in working on this issue for Hacktoberfest! |
Hi @Joycelyn-Chen, Sounds great! This issue is assigned to you. |
Hi, can I work on this? :) |
@aazam-gh Sure! The issue has been assigned to you. |
Hi @aazam-gh, I'm following up to check on any progress made regarding this issue. Could you please provide an update? Thanks 🙏 |
Hi sorry for not replying sooner. Seems like I need to have an appropriate nvidia driver
getting this error when running the make command to start services |
Hi @aazam-gh Did you run |
@chuang8511 Yes I am running that command |
|
Hi @aazam-gh Could you not use |
Let me try it. I will have to give user access to docker first |
@chuang8511 same result :(
|
You probably have NVIDIA driver installed on his machine which will enable GPU features in instill-core by default. If you really cannot run instill-core, you can just directly run pipeline-backend. Please just make sure that the unit test is ok. Will it be ok to you? |
Yes that will be fine. What command should I run then instead? |
|
Hey @aazam-gh how's it going? We're you able to resolve the issue? If not, you can join our Discord server: https://discord.gg/sevxWsqpGh where others may be able to help! |
Yeah, I won't have enough time to continue working on this |
Thanks @aazam-gh |
Thanks @aazam-gh for letting us know! Hey @VibhorGits I have assigned the issue to you now 🤝 Happy Hacking 👻 |
Hey @kuroxx, I’ve started reading the Slack documentation |
Hi @VibhorGits Currently, the users need to input the exact channel name to fetch the conversations in Slack. e.g. there are channel names called
When the users input |
Hey @chuang8511 my apology to interrupt you on the above issue I made the following changes in the tasks.json file "TASK_READ_MESSAGE": {
"instillShortDescription": "Get the latest message since specific date",
"input": {
"description": "Please input the channel name and the date that we want to start to read",
"instillUIOrder": 0,
"properties": {
"channel-name": {
"description": "Channel name, as displayed on Slack",
"instillAcceptFormats": [
"array"
],
"instillUIMultiline": true,
"instillUIOrder": 0,
"instillUpstreamTypes": [
"value",
"reference",
"template"
],
"title": "Channel Name",
"type": "array",
"items": {
"type": "string"
}
}, "TASK_WRITE_MESSAGE": {
"instillShortDescription": "send message to a specific channel",
"title": "Send Message",
"input": {
"description": "Input",
"instillUIOrder": 0,
"properties": {
"channel-name": {
"description": "Channel name, as displayed on Slack",
"instillAcceptFormats": [
"array"
],
"instillUIMultiline": true,
"instillUIOrder": 0,
"instillUpstreamTypes": [
"value",
"reference",
"template"
],
"title": "Channel Name",
"type": "array",
"items": {
"type": "string"
}
}, |
And, you don't have to modify the write part. |
Thank you @chuang8511 "TASK_READ_MESSAGE": {
"instillShortDescription": "Get the latest message since specific date",
"input": {
"description": "Please input the channel name and the date that we want to start to read",
"instillUIOrder": 0,
"properties": {
"channel-names": {
"description": "Enter a partial or complete channel name to fetch conversations.",
"instillAcceptFormats": [
"array"
],
"instillUIMultiline": true,
"instillUIOrder": 0,
"instillUpstreamTypes": [
"value",
"reference",
"template"
],
"title": "Channel Name",
"type": "array",
"items": {
"type": "string"
}
},
"channel-regex": {
"description": "Regular expression to filter channel names",
"instillAcceptFormats": [
"string"
],
"instillUIOrder": 1,
"title": "Channel Regex",
"type": "string"
}, |
After thinking again, how about removing regex part? regex for channel name may too difficult for users to input. |
Yea sure we can go with either one of them and suffix/prefix should be easier in most cases as you said. |
Yes, please! Thank you! |
Sure ! @chuang8511 "TASK_READ_MESSAGE": {
"instillShortDescription": "Get the latest message since specific date",
"input": {
"description": "Please input the channel name and the date that we want to start to read",
"instillUIOrder": 0,
"properties": {
"channel-names": {
"description": "Enter a partial or complete channel name to fetch conversations.",
"instillAcceptFormats": [
"array"
],
"instillUIMultiline": true,
"instillUIOrder": 0,
"instillUpstreamTypes": [
"value",
"reference",
"template"
],
"title": "Channel Name",
"type": "array",
"items": {
"type": "string"
}
},
"prefix": {
"description": "Prefix to add to each channel name",
"instillAcceptFormats": [
"string"
],
"instillUIOrder": 1,
"title": "Prefix",
"type": "string"
},
"suffix": {
"description": "Suffix to add to each channel name",
"instillAcceptFormats": [
"string"
],
"instillUIOrder": 2,
"title": "Suffix",
"type": "string"
},
"start-to-read-date": {
// REMAINING CODE
} |
@VibhorGits Please use this definition.
With only channel-names, the users can set the channel partially or completely.
|
No worries @chuang8511 "channel-names": {
"description": "Enter a partial or complete channel name to fetch conversations. For example, typing 'dev' retrieves conversations from all channels containing 'dev'.",
"instillAcceptFormats": [
"array"
],
"instillUIMultiline": true,
"instillUIOrder": 0,
"instillUpstreamTypes": [
"value",
"reference",
"template"
],
"title": "Channel Name",
"type": "array",
"items": {
"type": "string"
}
} |
Hey @kuroxx @chuang8511 I created a PR. |
Hey @VibhorGits as discussed on Discord, without being able to test your own code will make it difficult for our reviewers to check your code for you so I will de-assign you from this ticket now, Thanks! 🙏 |
Issue Description
Current State
Why We Want to Change?
Proposed Change
Rules for the Component Hackathon
Component Contribution Guideline | Documentation | Official Go Tutorial
The text was updated successfully, but these errors were encountered: