Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: Add support for 'public' attribute on github pages configuration #1045

Open
pkwarren opened this issue Jan 21, 2022 · 15 comments · Fixed by #1087 · May be fixed by #2540
Open

feature request: Add support for 'public' attribute on github pages configuration #1045

pkwarren opened this issue Jan 21, 2022 · 15 comments · Fixed by #1087 · May be fixed by #2540

Comments

@pkwarren
Copy link

We'd like to use the Github pages functionality of the terraform provider, however currently it doesn't support the github pages 'public' option: https://github.com/google/go-github/blob/178169fc04bc4a05ca48f98709cdd02ab5b556e3/github/repos_pages.go#L21

Terraform Version

v1.1.4

Affected Resource(s)

  • github_repository

Terraform Configuration Files

resource "github_repository" "example" {
  name        = "example"
  description = "My awesome web page"
  private = true
  pages {
    source {
      branch = "main"
      path   = "/docs"
    }
    # TODO: Doesn't work
    public = false
  }
}

Expected Behavior

Should be able to configure 'public = false' to limit visibility of github pages.

Actual Behavior

Option not yet supported.
@pkwarren
Copy link
Author

It looks like this will require fixes to upstream GitHub module: google/go-github#2261

@btkostner
Copy link
Contributor

Looks like it has been included upstream and will be included in the next release

@btkostner
Copy link
Contributor

go-github has released v43.0.0 which includes the fix here https://github.com/google/go-github/releases/tag/v43.0.0

@btkostner btkostner mentioned this issue Mar 7, 2022
Merged
@btkostner
Copy link
Contributor

This issue should not yet be closed

@btkostner btkostner mentioned this issue Apr 12, 2022
Closed
@kfcampbell
Copy link
Member

Oh I'm sorry! Thanks for catching this @btkostner.

@kfcampbell kfcampbell reopened this Apr 28, 2022
@github-actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jan 24, 2023
@btkostner
Copy link
Contributor

Currently waiting for PR to merge

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Jan 25, 2023
@ViacheslavKudinov
Copy link
Contributor

We need this feature! 🙏🏻

@dweaver33
Copy link

image

@calebworks
Copy link

Any updates on this?

@kfcampbell kfcampbell moved this to 🔥 Backlog in 🧰 Octokit Active Oct 20, 2023
@ViacheslavKudinov
Copy link
Contributor

Hello,
any updates or was it implemented ?

@Luis-3M
Copy link

Luis-3M commented Aug 21, 2024

What else is needed to make this feature available?

@btkostner
Copy link
Contributor

It looks like the upstream lower level API library has this feature released now. Someone just needs to open the PR for it in the terraform provider.

@lbartolotti-gocity
Copy link

I could use this feature too 👍

@BartolottiLuca BartolottiLuca linked a pull request Jan 17, 2025 that will close this issue
Open
4 tasks
@BartolottiLuca
Copy link

Hello, I've give this feature request a go, anyone know if I have to poke someone to get it reviewed or is just a matter of waiting?
#2540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@pkwarren @btkostner @dweaver33 @kfcampbell @Luis-3M @BartolottiLuca @ViacheslavKudinov @calebworks @lbartolotti-gocity