Remove ForceNew from GithubActionsOrganizationSecret #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2518
Before the change?
The provider currently forces a replace on any change to the secret plain text, encrypted value or visibility. However, the Github API allows in-place updates to secrets so this is effectively just forcing an unnecessary delete. This causes performance issues as in the linked ticket and also correctness issues when
create_before_destroyis used. (As it is by default, when this provider is used from Pulumi, see pulumi/pulumi-github#250 (comment))After the change?
Changes to the plaintext, encrypted value or visibility will cause an in place update of the secret. This results in faster updates and correct zero downtime updates to secrets.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!