-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency verification behavior in QVL Impacted by QVE Policy #402
Comments
Refactor code to reference issue: intel/SGXDataCenterAttestationPrimitives#402 Fixes: confidential-containers#386 -- part II Signed-off-by: ChengyuZhu6 <[email protected]>
This is by design because we want to guarantee the default behavior of QVL/QvE keep unchanged with old DCAP release. In the other words, the legacy mode So we added two new modes |
Refactor code to reference issue: intel/SGXDataCenterAttestationPrimitives#402 Fixes: confidential-containers#386 -- part II Signed-off-by: ChengyuZhu6 <[email protected]>
Refactor code to reference issue: intel/SGXDataCenterAttestationPrimitives#402 Fixes: confidential-containers#386 -- part II Signed-off-by: ChengyuZhu6 <[email protected]>
Thanks for your information. |
@hyjiang The case here is that the user has explicitly chosen not to use QVE so why they still need to care about the load policy |
You're right, the overall solution doesn't seem perfect at the moment. This is because the previous QVL/QvE did not support multithreading, and when we consider adding multithreading support, we need to keep the original behavior unchanged. |
Do you have the behavior documented so that we could point our code to it? |
We have observed that the concurrency logic in QVL is being influenced by QVE policy. This behavior seems unintended and could lead to inconsistent handling of concurrent verifiction requests in QVL.
Expected Behavior
The
qve_policy
is designed to impact QVE verification exclusively. Ideally,qve_policy
should not affect the QVL's functionality.Current Behavior
Currently, QVL processes received verification requests serially by default. The default value of
qve_policy
is set toSGX_QL_PERSISTENT
(which is equivalent toSGX_QL_DEFAULT
). However, when we configure theqve_policy
value toSGX_QL_PERSISTENT_QVE_MULTI_THREAD
, QVL is capable of processing verification requests concurrently.SGXDataCenterAttestationPrimitives/QuoteVerification/dcap_quoteverify/sgx_dcap_quoteverify.cpp
Lines 504 to 515 in 45554a7
The text was updated successfully, but these errors were encountered: