Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replacing to ruff python instead black and flake8 #4534

Open
slowy07 opened this issue Oct 28, 2024 · 1 comment
Open

feat: replacing to ruff python instead black and flake8 #4534

slowy07 opened this issue Oct 28, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@slowy07
Copy link

slowy07 commented Oct 28, 2024

Description

i thinks its be better using more responsive or fast formatter and linter check using ruff cause black its issue at perfomance on specially scaleable project, for information about ruff you can check here

image

for style guide from python you can check on ruff readme.md

@slowy07 slowy07 added enhancement New feature or request good first issue Good for newcomers labels Oct 28, 2024
@terriko
Copy link
Contributor

terriko commented Oct 28, 2024

Duplicating what I said in the pull request:
I'm tentatively interested in giving this a shot but...

  • I need documentation for new contributors
  • I need to run it in parallel with black and flake8 for a bit to see if they're finding different stuff of interest
  • We need to do some other changes to make sure pyproject.toml works as expected -- last time it resulted in a bunch of build tools breaking because the rest of our config is in setup.py and some tools assume if you have pyproject.toml it's what you need to use.
  • I am completely swamped with other work right now and have barely been allowed to carve out time to handle the "easy" pull requests so unless you're prepared to do a lot of work this one is going to languish for quite some time.

I'm going to approve this to run and see if anything weird happens when it runs so we can decide what to do next, but just be warned that there's a bunch of work that would need to be done before we can really start using ruff to replace the existing linters.

I will add here that a difference in a few seconds for a linter basically isn't something I care about -- we're talking a full test suite that takes an hour to run, so the bigger concern for us is how much time it'll take to fix the toolchain issues and docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants