Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Improvements to align CTS and Spec for Program #17094

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

martygrant
Copy link
Contributor

Migrated from oneapi-src/unified-runtime#2697

  • All error returns for urProgramCreateWithIL are now covered, and a Success case with different properties has been added
  • Passing properties to urProgramCreateWithBinary
  • Added tests for passing options to urProgramCompile
    • Not passing any options to urProgramLink as there are no common platform independent options that I'm aware of
  • Added extra validation for urProgramRetain/Release
  • Added unowned native handle test for urProgramCreateWithNativeHandle

@martygrant
Copy link
Contributor Author

martygrant commented Feb 21, 2025

Pre commit AMD job is failing with Memory access fault by GPU node-1 (Agent handle: 0x10478090) on address 0x7b62a0014000. Reason: Page not present or supervisor privilege. this is being tracked here #10460

Pre commit CUDA job is a flaky test being tracked here #17026 HostInteropTask/interop-task-cuda-buffer-migrate.cpp

Pre commit ARC job failure in being tracked here #17177

@martygrant
Copy link
Contributor Author

@intel/bindless-images-reviewers @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda need a review for this PR please

Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA LGTM, though as a pedant I couldn't help but leave a nit 😉

- All error returns for urProgramCreateWithIL are now covered, and a Success case with different properties has been added
- Passing properties to urProgramCreateWithBinary
- Added tests for passing options to urProgramCompile
- Added extra validation for urProgramRetain/Release
- Added unowned native handle test for urProgramCreateWithNativeHandle
@martygrant martygrant force-pushed the martin/program-cts-spec-gap branch from 4b59eb0 to 081270f Compare February 24, 2025 16:38
@martygrant martygrant merged commit 8fa2a12 into intel:sycl Feb 26, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants