-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UR] Improvements to align CTS and Spec for Program #17094
Conversation
e6a000b
to
f921d6e
Compare
f921d6e
to
b99032d
Compare
Pre commit AMD job is failing with Pre commit CUDA job is a flaky test being tracked here #17026 HostInteropTask/interop-task-cuda-buffer-migrate.cpp Pre commit ARC job failure in being tracked here #17177 |
b99032d
to
4b59eb0
Compare
@intel/bindless-images-reviewers @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda need a review for this PR please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA LGTM, though as a pedant I couldn't help but leave a nit 😉
- All error returns for urProgramCreateWithIL are now covered, and a Success case with different properties has been added - Passing properties to urProgramCreateWithBinary - Added tests for passing options to urProgramCompile - Added extra validation for urProgramRetain/Release - Added unowned native handle test for urProgramCreateWithNativeHandle
4b59eb0
to
081270f
Compare
Migrated from oneapi-src/unified-runtime#2697